New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Support zstd compression in BGEN files #12576
Conversation
CHANGELOG: `hl.import_bgen` and `hl.export_bgen` now support compression with Zstd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small maintainability issue around the ids for compression.
val writeHeader = exportType == ExportType.PARALLEL_HEADER_IN_SHARD | ||
val partWriter = BGENPartitionWriter(tm, entriesFieldName, writeHeader) | ||
val compressionInt = compressionCodec match { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to make this some kind of enum, or if that's too much, named constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
* [query] Support zstd compression in BGEN files CHANGELOG: `hl.import_bgen` and `hl.export_bgen` now support compression with Zstd. * address comments
CHANGELOG:
hl.import_bgen
andhl.export_bgen
now support compression with Zstd.